Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundler: fix extra bugs #1127

Merged
merged 6 commits into from
Oct 3, 2020
Merged

bundler: fix extra bugs #1127

merged 6 commits into from
Oct 3, 2020

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 3, 2020 •
edited
Loading

swc_bundler:

  • Prevent invalid output like export * as helpers
  • Prevent stack overflow which occurs while bundling https://deno.land/x/oak@v6.2.0/mod.ts

swc_ecma_transforms:

  • Migrate inlining pass to VisitMut

Note: The stack overflow is caused by inlining pass. I tested in various ways, and I concluded that stack overflow will be fixed by migrating inlining pass from Fold to VisitMut.

@kdy1 kdy1 added this to the v1.2.35 milestone Oct 3, 2020
@kdy1 kdy1 self-assigned this Oct 3, 2020
@kdy1 kdy1 mentioned this pull request Oct 3, 2020
Closed
@kdy1 kdy1 marked this pull request as ready for review October 3, 2020 15:19
@kdy1 kdy1 merged commit 205ce4e into swc-project:master Oct 3, 2020
@kdy1 kdy1 deleted the issues branch October 3, 2020 15:19
@kdy1 kdy1 mentioned this pull request Dec 20, 2020
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.2.35
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kdy1