Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: comments in empty file should be in leading comments #1879

Merged
merged 7 commits into from Jul 3, 2021
Merged

fix: comments in empty file should be in leading comments #1879

merged 7 commits into from Jul 3, 2021

Conversation

dsherret
Copy link
Contributor

@dsherret dsherret commented Jul 1, 2021

Fixes #1878

@dsherret dsherret mentioned this pull request Jul 1, 2021
Closed
kdy1
kdy1 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although some tests failed.

@dsherret
Copy link
Contributor Author

dsherret commented Jul 2, 2021

@kdy1 thanks! I missed that. It passes now.

@kdy1 kdy1 merged commit 534c0b1 into swc-project:master Jul 3, 2021
@kdy1 kdy1 added this to the v1.2.63 milestone Jul 3, 2021
@dsherret dsherret mentioned this pull request Jul 5, 2021
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.63
Development

Successfully merging this pull request may close these issues.

File containing comments should have comments in leading instead of trailing
2 participants
@dsherret @kdy1