fix(es/minifier): Fix mapbox
#3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
commented
Feb 7, 2022
| @@ -1,4 +1,6 @@ | |||
| function x() { | |||
| (class Baz {}); | |||
| class Foo {} | |||
| (class a { | |||
There was a problem hiding this comment.
This change is due to we didn't implement the option of terser to keep class names.
|
I'll merge it as code changes are quite trivial |
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Feb 8, 2022
This applies - swc-project/swc#3462 This resolves #30237 (comment) - swc-project/swc#3463 This resolves #30237 (comment) - swc-project/swc#3480 This resolves #30237 (comment)
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This applies - swc-project/swc#3462 This resolves vercel#30237 (comment) - swc-project/swc#3463 This resolves vercel#30237 (comment) - swc-project/swc#3480 This resolves vercel#30237 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
swc_ecma_minifier:
mangler: Handle the identifiers of class expressions correctly.As shown above, name mangler assigns
ito a class expression and uses it again inside the class, as the name of a parameter.This results in an exception from
new i.This is a fixed version.
(I copy-pasted it to js beutifier)
Related issue (if exists):