fix: recovery mode for function #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Feb 16, 2022
| "WhiteSpace": { | ||
| "value": " " | ||
| } | ||
| } |
There was a problem hiding this comment.
Previously we lost whitespaces on tokens (it is not good), I found some more edge cases, and will it soon
kdy1
approved these changes
Feb 17, 2022
kdy1
approved these changes
Feb 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix recovery mode for
function(regression in next.js)Ideally we should refactor this logic more and consume components values firstly, when try to resolve to
Vec<Value>, if failed keep them as is, if not failed applyVec<Value>nodes, but it requires more refactor and can take a time (I will focus on it in this week, so we will not have such regressions in future)No
Related issue (if exists):
No