Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): emit source map columns #4646

Merged
merged 4 commits into from May 13, 2022
Merged

feat(common): emit source map columns #4646

merged 4 commits into from May 13, 2022

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented May 12, 2022 •
edited

Description:

Optionally emit source map columns, use true as default value

BREAKING CHANGE:
No breaking changes

Related issue (if exists):
closes #4637

@CLAassistant
Copy link

CLAassistant commented May 12, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@h-a-n-a h-a-n-a mentioned this pull request May 12, 2022
Closed
@kdy1 kdy1 added this to the Planned milestone May 13, 2022
@h-a-n-a h-a-n-a force-pushed the feat/source-map-col branch 2 times, most recently from ff0a309 to a0a9624 Compare May 13, 2022 04:19
kdy1
kdy1 approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_common
  • swc --breaking

kdy1
kdy1 requested changes May 13, 2022
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh CI failed

You can run UPDATE=1 cargo test to update test references

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 13, 2022

@kdy1 option output-format seems not working with cargo bench, which results failure of CI. Could you help me with that?

@kdy1
Copy link
Member

kdy1 commented May 13, 2022

I'll fix it with another PR.
The benchmark is not marked as required so I can still merge it

@kdy1 kdy1 enabled auto-merge (squash) May 13, 2022 08:28
@h-a-n-a h-a-n-a changed the title feat: emit source map columns feat(swc): emit source map columns May 13, 2022
@h-a-n-a h-a-n-a changed the title feat(swc): emit source map columns feat(common): emit source map columns May 13, 2022
@kdy1 kdy1 merged commit b6f904b into swc-project:main May 13, 2022
@h-a-n-a h-a-n-a deleted the feat/source-map-col branch May 13, 2022 08:53
@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 13, 2022

@kdy1 would you like to publish swc_common as well?

@kdy1
Copy link
Member

kdy1 commented May 13, 2022

Published with f63be2f

Btw, if it's fine to ask, is this patch useful for rolldown?

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 13, 2022

Published with f63be2f

Btw, if it's fine to ask, is this patch useful for rolldown?

Thank you for quick response!

It will be used as a patch for a bundler developing in my company

@kdy1
Copy link
Member

kdy1 commented May 13, 2022

I see!
I asked because I started working on the new bundler for swc today 😄

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 13, 2022

I see! I asked because I started working on the new bundler for swc today 😄

Wow! It's really nice to hear that a newly designed swc bundler is under developmenet from Vercel team! When would it be released? I'm looking forward to it!.

@kdy1
Copy link
Member

kdy1 commented May 13, 2022

Not sure at the moment.
I think I found a working design, but there are so many tasks as it has lots of features

@kdy1 kdy1 modified the milestones: Planned, v1.2.184 May 15, 2022
@kdy1
Copy link
Member

kdy1 commented May 26, 2022

@h-a-n-a If you are okay with sharing some information, can you tell me about some requirements? (Email/Discord is also fine)
The more requirements I know, the better will be the bundler

@h-a-n-a
Copy link
Contributor Author

h-a-n-a commented May 26, 2022

@h-a-n-a If you are okay with sharing some information, can you tell me about some requirements? (Email/Discord is also fine) The more requirements I know, the better will be the bundler

@kdy1 Sure, you can find me and my team on discord. Mine is __H#7510

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.185
Development

Successfully merging this pull request may close these issues.

Optional column mapping for codegenerator
3 participants
@h-a-n-a @CLAassistant @kdy1