feat(swc/plugin_macro): export new interface for getting plugin schema version (#5060: Part 5) #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
previously approved these changes
Jul 9, 2022
kwonoj
force-pushed
the
feat-plugin-schema-version-export-retry
branch
from
c21d150
to
8479d6c
Compare
kdy1
previously approved these changes
Jul 9, 2022
kwonoj
force-pushed
the
feat-plugin-schema-version-export-retry
branch
from
8479d6c
to
f00f6cd
Compare
kdy1
approved these changes
Jul 9, 2022
kdy1
previously approved these changes
Jul 9, 2022
kwonoj
force-pushed
the
feat-plugin-schema-version-export-retry
branch
from
f00f6cd
to
6de12a2
Compare
kwonoj
force-pushed
the
feat-plugin-schema-version-export-retry
branch
from
6de12a2
to
4c5da7b
Compare
|
@kdy1 seems PR is ok now? |
kdy1
approved these changes
Jul 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Retrying #5158 for the CI.
This PR adds a new fn in plugin's macro side, returns schema version defined in
swc_commonat the moment of compilation. To support per-build time flags, also introduces features to the downstream pkg from top level (binding-*).Changes are based on theoritical workflow I have in mind, which means this is possibly not correct and would require further refactorings. But having each step helps to setting up actual (manually) testable workflow.
Once this goes in, I'll pause bit and try to attempt refactor integration test for the plugin. I feel it's hitting tipping point to worth better ergonomics to test more than simple transformation execution. Probably will need node.js side testing as well for whole integrations.
BREAKING CHANGE:
Related issue (if exists):
#5060