feat(es/minifier): Inline lazy inited vars #5737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Austaras
force-pushed
the
main
branch
2 times, most recently
from
6b34d63
to
95bf24b
Compare
kdy1
reviewed
Sep 5, 2022
crates/swc_ecma_minifier/tests/terser/compress/reduce_vars/conditional_nested_3/output.js
Outdated
Show resolved
Hide resolved
Austaras
commented
Sep 5, 2022
Austaras
force-pushed
the
main
branch
3 times, most recently
from
97c21c8
to
57a427b
Compare
kdy1
reviewed
Sep 6, 2022
|
Seems like it has a noticeable impact on performance. |
|
How to do benchmark? However I'm afraid performance cost is unavoidable |
|
Can't we store it in |
|
To run benchmark, you can do |
|
I know where is wrong. I'll fix it tonight |
|
Can you rebase, please? |
Austaras
force-pushed
the
main
branch
2 times, most recently
from
a1462d3
to
93f9299
Compare
Austaras
commented
Sep 6, 2022
crates/swc/tests/tsc-references/privateNameComputedPropertyName2(target=es2022).2.minified.js
Outdated
Show resolved
Hide resolved
kdy1
requested changes
Sep 7, 2022
crates/swc_ecma_minifier/tests/fixture/issues/firebase-core/1/output.js
Outdated
Show resolved
Hide resolved
Austaras
force-pushed
the
main
branch
3 times, most recently
from
a0775dd
to
e2f1e4d
Compare
|
Some personal TODO export function TinyColor(v, i) {
var mod,
r1,
g1,
rgb1 =
((r1 = [v, v, v, v, v, v][(mod = i % 6)]),
(g1 = [v, v, v, v, v, v][mod]),
{
r: 255 * r1,
g: 255 * g1,
b: 255 * [p, p, t, v, v, q][mod],
});
this.isValid = rgb1.ok;
}export function x() {
var b, c
c = (b = x(), console.log(), b)
console.log(c)
}seems both are about sequence expression |
|
Can you rebase? |
kdy1
previously approved these changes
Sep 8, 2022
kdy1
approved these changes
Sep 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):
related #5559