feat(es/minifier): Distinguish calls in alias analyzer #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
changed the title
kdy1
changed the title
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
jridgewell
previously approved these changes
Oct 7, 2022
| max_num: usize, | ||
| ) -> Result<FxHashSet<Id>, ()> { | ||
| ) -> Result<FxHashSet<Access>, ()> { | ||
| let init = | ||
| HashSet::with_capacity_and_hasher(max_num, BuildHasherDefault::<FxHasher>::default()); | ||
| ids.into_iter().try_fold(init, |mut res, id| { |
There was a problem hiding this comment.
GH won't let me comment on the below lines, but is the ranges var necessary? Seems like this could be a while loop:
let mut i = 0;
while i < ids.len() {
…
i += 1
}There was a problem hiding this comment.
@Brooooooklyn Can you help with this?
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
swc-bot
reviewed
Oct 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves alias analyzer by distinguishing call and reference, thus reducing the number of identifiers.
Related issue: