Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(atoms): Use thin pointer for Atom #6135

Merged
merged 9 commits into from
Oct 13, 2022
Merged

perf(atoms): Use thin pointer for Atom #6135

merged 9 commits into from
Oct 13, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 13, 2022

Description:

This PR changes the size of Atom type to usize from 2 * usize`.

Related issue:

After merging this, I'll work on complete transition to our own Atom type from string_cache::Atom.

@kdy1 kdy1 added this to the Planned milestone Oct 13, 2022
@kdy1 kdy1 self-assigned this Oct 13, 2022
@kdy1 kdy1 marked this pull request as ready for review October 13, 2022 04:56
@kdy1 kdy1 enabled auto-merge (squash) October 13, 2022 04:56
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 13, 2022
View reviewed changes
kdy1
kdy1 commented Oct 13, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reset ci

swc-bump:

  • swc_atoms

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 13, 2022
View reviewed changes
swc-bot
swc-bot reviewed Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 9c8ec0e into swc-project:main Oct 13, 2022
@kdy1 kdy1 deleted the atom branch October 13, 2022 06:09
@kdy1 kdy1 modified the milestones: Planned, v1.3.8 Oct 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @swc-bot