Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/transform_base): should add correct parentheses to OptChainExpr in MemberExpr #6639

Merged
merged 3 commits into from Dec 14, 2022

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Dec 13, 2022

Description:

BREAKING CHANGE:

Related issue (if exists):

Fix #6459

@hyf0 hyf0 force-pushed the hyf_fix_6459 branch 2 times, most recently from 72679d9 to 2389bd0 Compare December 13, 2022 13:05
@hyf0 hyf0 changed the title fix(es/transform_base): should add correct parens for optioanl chaining expression fix(es/transform_base): should add correct parentheses for optioanl chaining expression Dec 13, 2022
@hyf0 hyf0 changed the title fix(es/transform_base): should add correct parentheses for optioanl chaining expression fix(es/transform_base): should add correct parentheses to OptChainExpr in MemberExpr Dec 13, 2022
@hyf0 hyf0 marked this pull request as ready for review December 13, 2022 14:19
@kdy1 kdy1 self-assigned this Dec 14, 2022
@kdy1 kdy1 added this to the Planned milestone Dec 14, 2022
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


swc-bump:

  • swc_ecma_transforms_base

@kdy1 kdy1 enabled auto-merge (squash) December 14, 2022 04:03
@kdy1 kdy1 merged commit be5ea7f into swc-project:main Dec 14, 2022
@kdy1 kdy1 modified the milestones: Planned, v1.3.23 Dec 14, 2022
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Optional chaining with type assertion is transpiled incorrectly when targetting es2020 or later
2 participants