fix(plugin): Make span_to_source use dedicated function
#6853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
commented
Jan 25, 2023
kwonoj
approved these changes
Jan 25, 2023
swc-bot
reviewed
Jan 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
NOTE: This is not a fundamental fix, and a memory leak still exists in
__lookup_byte_offset_proxy. See #6854 for more details. This PR makesspan_to_sourcenot use__lookup_byte_offset_proxy.The memory leak is gone, and the memory usage is not increasing while running the test.
Related issue:
span_to_sourceis extremely inefficient for Wasm plugins #6852.