Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/transforms): handle member obj in missing else branch #7027

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

if self.scope.namespace.contains(&member_obj.to_id()) {
let module_name = &member_obj.sym;

if let Some(module_name) = obj
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manage to move this if statement to the match arm.

@magic-akari magic-akari marked this pull request as ready for review March 7, 2023 02:29
@kdy1 kdy1 added this to the Planned milestone Mar 7, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!



swc-bump:

  • swc_ecma_transforms_optimization

@kdy1 kdy1 enabled auto-merge (squash) March 7, 2023 02:36
@kdy1 kdy1 merged commit 5c7c8e0 into swc-project:main Mar 7, 2023
@magic-akari magic-akari deleted the fix/issue-7025 branch March 10, 2023 02:51
@kdy1 kdy1 modified the milestones: Planned, v1.3.39 Mar 10, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wrong output for "jsc.transform.constModules" configuration with object const
2 participants