fix(es/transform_typescript): should consider A as a type in export { type A }
#7196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyf0
commented
Apr 3, 2023
| if let ModuleExportName::Ident(local_ident) = &n.orig { | ||
| // If the stored exported `Id` is a value, we just leave it here. | ||
| // If the stored exported `Id` is both a type and value, we consider it's a | ||
| // value. See https://github.com/denoland/deno/issues/8978 |
There was a problem hiding this comment.
I thought this was easy but not easy as I thought when I met denoland/deno#8978.
kdy1
approved these changes
Apr 4, 2023
|
I believe this may not be a correct fix. You should add the following test case. import { A } from "./a.ts";
new A();
export { type A }; |
Good catch! There is still a lot to learn to me. I'll continue the fix weekend and if you want to take this, be my guest. |
kdy1
added a commit
to kdy1/swc
that referenced
this pull request
Apr 29, 2023
…swc-project#7196)" This reverts commit ddfbc93.
kdy1
added a commit
that referenced
this pull request
Apr 29, 2023
**Related issue:** - Reverts #7196. - vercel/turbo#4747.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #7076.
BREAKING CHANGE:
Related issue (if exists):