Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin/runner): Update wasmer to v3 #7197

Merged
merged 13 commits into from Apr 10, 2023
Merged

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Apr 3, 2023

Description:

This PR reattempts #5456.

Most of changes are for the breaking changes of wasmer@3, as well as enabling rkyv's strict mode (#6922). This could not be seperated since wasmer@3 enables strict mode by default without way to turn it off.

There are couple of changes worth to note:

@kwonoj kwonoj marked this pull request as draft April 3, 2023 17:17
@kdy1 kdy1 self-assigned this Apr 4, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kwonoj
✅ swc-bot
❌ djkoloski
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ kwonoj
❌ djkoloski
You have signed the CLA already but the status is still pending? Let us recheck it.

@kwonoj kwonoj force-pushed the feat-wasmer-3 branch 17 times, most recently from faad21d to 492dc7c Compare April 9, 2023 07:44
@kwonoj kwonoj marked this pull request as ready for review April 9, 2023 08:38
@kwonoj
Copy link
Member Author

kwonoj commented Apr 9, 2023

@kwonoj kwonoj changed the title [DONOTMERGEYET][WIP] feat(plugin_runner): wasmer@3 feat(plugin_runner): wasmer@3 Apr 9, 2023
@kdy1
Copy link
Member

kdy1 commented Apr 9, 2023

About cargo deny, you can add a crate to allowlist

About CLA, we can ignore it.

@kwonoj kwonoj force-pushed the feat-wasmer-3 branch 3 times, most recently from c62adf2 to 079932a Compare April 9, 2023 09:07
@kwonoj
Copy link
Member Author

kwonoj commented Apr 9, 2023

It seems we can't make an exception for the unlicensed pkgs, (https://github.com/swc-project/swc/actions/runs/4649770971/jobs/8228348524?pr=7197#step:5:15) only global config would work. EmbarkStudios/cargo-deny#451

@kdy1 kdy1 changed the title feat(plugin_runner): wasmer@3 feat(plugin/runner): Update wasmer to v3 Apr 10, 2023
@kdy1 kdy1 added this to the Planned milestone Apr 10, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!


swc-bump:

  • swc_atoms --breaking
  • swc_common --breaking

@kdy1 kdy1 enabled auto-merge (squash) April 10, 2023 02:56
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 56bdacc into swc-project:main Apr 10, 2023
127 of 128 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.48 Apr 10, 2023
@kdy1 kdy1 mentioned this pull request Apr 17, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants