-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/compat): Generate OptCall
for OptCall
for private fields
#8031
Conversation
@@ -400,7 +398,11 @@ impl VisitMut for Fixer<'_> { | |||
fn visit_mut_call_expr(&mut self, node: &mut CallExpr) { | |||
let old = self.visit_call(&mut node.args, &mut node.callee); | |||
if let Callee::Expr(e) = &mut node.callee { | |||
self.wrap_callee(e) | |||
if let Expr::OptChain(_) = &**e { | |||
self.wrap(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary -- swc parser and paren_remover won't generate such structure, but it's better to be safe.
d2fbdc0
to
cd65db4
Compare
OptCall
for OptCall
for private fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_transforms_compat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
Related issue: