Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/lint): Ignore ambient context binding #8368

Merged
merged 3 commits into from
Dec 3, 2023
Merged

fix(es/lint): Ignore ambient context binding #8368

merged 3 commits into from
Dec 3, 2023

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari marked this pull request as ready for review December 2, 2023 12:18
@magic-akari magic-akari requested a review from a team as a code owner December 2, 2023 12:18
kdy1
kdy1 approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_lints

@kdy1 kdy1 enabled auto-merge (squash) December 3, 2023 00:17
@kdy1 kdy1 added this to the Planned milestone Dec 3, 2023
swc-bot
swc-bot reviewed Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 83c8fe5 into swc-project:main Dec 3, 2023
276 of 278 checks passed
@magic-akari magic-akari deleted the fix/issue-8367 branch December 5, 2023 03:12
@kdy1 kdy1 modified the milestones: Planned, v1.3.101 Dec 18, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.101
Development

Successfully merging this pull request may close these issues.

False positive lint report: Function can be merged with ambient context class
3 participants
@magic-akari @kdy1 @swc-bot