Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for linux riscv64 gnu #8428

Closed
wants to merge 1 commit into from
Closed

Conversation

kxxt
Copy link

@kxxt kxxt commented Dec 16, 2023

Description:

This PR adds build for riscv64 linux gnu target.

packages/html and packages/xml seem to reference non existent crates like bindings/binding_html_node so I didn't regenerate the binding.js file for them. Looks like @swc-lab/xml and @swc-lab/html are not published to npm anyway.

@kxxt kxxt requested a review from a team as a code owner December 16, 2023 03:33
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kwonoj
Copy link
Member

kwonoj commented Dec 16, 2023

SWC currently have amount of platform targets and we actually want to reduce the numbers. What's the production system uses this target and how many users out there?

@kxxt
Copy link
Author

kxxt commented Dec 16, 2023

SWC currently have amount of platform targets and we actually want to reduce the numbers. What's the production system uses this target and how many users out there?

Distro packagers are packaging some applications that uses swc. Frankly speaking I don't know if there is any production system uses swc on this target now. The user base is expected to grow in the future as RISC-V develops and matures.

@kwonoj
Copy link
Member

kwonoj commented Dec 16, 2023

Expanding new target is not a one time workb it is continuous maintenance to sve compatibility for the dependencies / code in the swc's core. Please provide suffecient reasoning why swc/core have to manage this targets, happy to discuss internally if there are suffecient usecase.

Please use gh discussion with RFC for those. I'll close PR for now to avoid PR hanging without accepting.

@kwonoj kwonoj closed this Dec 16, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants