Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css/parser): Fix parsing of hsla(var(--foo), 1) #8443

Merged
merged 9 commits into from
Dec 23, 2023
Merged

fix(css/parser): Fix parsing of hsla(var(--foo), 1) #8443

merged 9 commits into from
Dec 23, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Dec 21, 2023 •
edited

Description:

.test {
    border-color: hsla(var(--ds-gray-200-value), 1);
}

should be compiled as

.test {
    border-color: hsla(var(--ds-gray-200-value), 1);
}

Previously, it was

.test {
    border-color: hsla(var(--ds-gray-200-value),);
}

Related issue:

@kdy1 kdy1 added this to the Planned milestone Dec 21, 2023
@kdy1 kdy1 self-assigned this Dec 21, 2023
@kdy1 kdy1 changed the title fix(css/compat): Fix transform of hsla fix(css/parser): Fix parsaing of hsla(var(--foo), 1) Dec 21, 2023
kdy1
kdy1 commented Dec 21, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_css_parser

@kdy1 kdy1 marked this pull request as ready for review December 21, 2023 10:55
@kdy1 kdy1 requested a review from a team as a code owner December 21, 2023 10:55
@kdy1 kdy1 changed the title fix(css/parser): Fix parsaing of hsla(var(--foo), 1) fix(css/parser): Fix parsing of hsla(var(--foo), 1) Dec 21, 2023
@kdy1 kdy1 merged commit d89b60a into swc-project:main Dec 23, 2023
140 of 142 checks passed
@kdy1 kdy1 deleted the v-l-2175 branch December 23, 2023 03:39
@kdy1 kdy1 modified the milestones: Planned, v1.3.102 Dec 31, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.102
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kdy1