Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Replace string_cache with hstr in ARCHITECTURE.md #8487

Merged
merged 1 commit into from
Jan 9, 2024
Merged

doc: Replace string_cache with hstr in ARCHITECTURE.md #8487

merged 1 commit into from
Jan 9, 2024

Conversation

takashimamorino
Copy link
Contributor

Description:
string_cache has already been replace by #8126

BREAKING CHANGE:

Related issue (if exists):

@takashimamorino takashimamorino requested a review from a team as a code owner January 8, 2024 05:29
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kdy1
kdy1 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 changed the title docs: replace string_cache with hstr in ARCHITECTURE.md doc: Replace string_cache with hstr in ARCHITECTURE.md Jan 9, 2024
@kdy1 kdy1 merged commit abd7c51 into swc-project:main Jan 9, 2024
137 of 140 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.103 Jan 9, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.103
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takashimamorino @CLAassistant @kdy1