Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Abort property hoister on this usage #8647

Merged
merged 3 commits into from
Feb 19, 2024
Merged

fix(es/minifier): Abort property hoister on this usage #8647

merged 3 commits into from
Feb 19, 2024
+554 −10

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 19, 2024

@kdy1 kdy1 added this to the Planned milestone Feb 19, 2024
@kdy1 kdy1 self-assigned this Feb 19, 2024
@kdy1 kdy1 requested a review from a team as a code owner February 19, 2024 04:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: 0b28931

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title fix(es/minifier): Fix hoist_props fix(es/minifier): Abort property hoister on this usage Feb 19, 2024
@kdy1 kdy1 enabled auto-merge (squash) February 19, 2024 04:01
kdy1
kdy1 commented Feb 19, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 disabled auto-merge February 19, 2024 04:02
@kdy1 kdy1 enabled auto-merge (squash) February 19, 2024 04:02
@kdy1
Copy link
Member Author

kdy1 commented Feb 19, 2024

Skipping review process as I'm going to publish this fix asap

@kdy1 kdy1 disabled auto-merge February 19, 2024 04:09
@kdy1 kdy1 merged commit 9715320 into swc-project:main Feb 19, 2024
142 checks passed
@kdy1 kdy1 deleted the issue-8643 branch February 19, 2024 04:09
This was referenced Feb 19, 2024
Merged
Merged
@kdy1 kdy1 modified the milestones: Planned, v1.4.2 Feb 19, 2024
kdy1 added a commit to vercel/turbo that referenced this pull request Feb 20, 2024
@kdy1
Update swc_core to v0.90.10 (#7416)
2f574b3 
### Description

Update SWC crates, to apply swc-project/swc#8647

### Testing Instructions

See vercel/next.js#62222. It's next.js counterpart.

Closes PACK-2530
kdy1 added a commit to vercel/next.js that referenced this pull request Feb 20, 2024
@kdy1
Update swc_core to v0.90.10 (#62222)
a78ed66 
### What?

Update SWC crates.

### Why?

There was an important bug fix in SWC.

 - swc-project/swc#8647

### How?



Closes PACK-2529
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.

Regression: "this is undefined" when minifying @google/model-viewer with @swc/core 1.4.1 or newer
1 participant
@kdy1