Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Abort IIFE invoker in function parameters #8828

Merged
merged 19 commits into from
Apr 9, 2024
Merged

fix(es/minifier): Abort IIFE invoker in function parameters #8828

merged 19 commits into from
Apr 9, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 9, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Apr 9, 2024
@kdy1 kdy1 self-assigned this Apr 9, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2024 •
edited

⚠️ No Changeset found

Latest commit: e48b62e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Make inliner declare variables correctly Apr 9, 2024
@kdy1 kdy1 changed the title fix(es/minifier): Make inliner declare variables correctly fix(es/minifier): Abort IIFE invoker in function parameters Apr 9, 2024
@kdy1 kdy1 marked this pull request as ready for review April 9, 2024 05:46
@kdy1 kdy1 requested a review from a team as a code owner April 9, 2024 05:46
kdy1
kdy1 commented Apr 9, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) April 9, 2024 05:47
@kdy1 kdy1 disabled auto-merge April 9, 2024 06:22
@kdy1 kdy1 merged commit ebb68db into swc-project:main Apr 9, 2024
142 checks passed
@kdy1 kdy1 deleted the issue-8826 branch April 9, 2024 06:22
@kdy1 kdy1 modified the milestones: Planned, v1.4.13 Apr 9, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators May 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Austaras Austaras Austaras approved these changes

@kodiakhq kodiakhq[bot] kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.4.13
Development

Successfully merging this pull request may close these issues.

minify: inlined variable declaration missing
2 participants
@kdy1 @Austaras