Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix a bug about Tpl => Str #8934

Merged
merged 8 commits into from
May 8, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 7, 2024

Description:

I added the method to swc_ecma_ast to reuse it from plugins.

Related issue:

@kdy1 kdy1 added this to the Planned milestone May 7, 2024
@kdy1 kdy1 requested review from magic-akari and Austaras May 7, 2024 13:38
@kdy1 kdy1 self-assigned this May 7, 2024
@kdy1 kdy1 requested a review from a team as a code owner May 7, 2024 13:38
Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: ba7e8be

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes May 7, 2024
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_ast
  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) May 8, 2024 01:22
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit d4be383 into swc-project:main May 8, 2024
148 checks passed
@kdy1 kdy1 deleted the issue-8931 branch May 8, 2024 07:25
@kdy1 kdy1 modified the milestones: Planned, v1.5.5 May 8, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

SWC incorrectly handles double backslashes in template literals
3 participants