Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/lexer): Make lexing of string literals faster #9077

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 18, 2024

Description:

We don't need to push a character at a time. This profiling result does not include improvements from #9076

Benchmarking es/lexer/cal-com
es/lexer/cal-com        time:   [6.4555 ms 6.4936 ms 6.5368 ms]

@kdy1 kdy1 added this to the Planned milestone Jun 18, 2024
@kdy1 kdy1 self-assigned this Jun 18, 2024
@kdy1 kdy1 requested a review from a team as a code owner June 18, 2024 08:08
@kdy1 kdy1 enabled auto-merge (squash) June 18, 2024 08:08
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_parser
  • swc_core

@kdy1 kdy1 disabled auto-merge June 18, 2024 08:09
@kdy1 kdy1 enabled auto-merge (squash) June 18, 2024 08:09
@kdy1 kdy1 disabled auto-merge June 18, 2024 08:27
@kdy1 kdy1 merged commit 373bac5 into swc-project:main Jun 18, 2024
147 checks passed
@kdy1 kdy1 deleted the lexer-str branch June 18, 2024 08:27
@kdy1 kdy1 modified the milestones: Planned, v1.6.3 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant