Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention lto in plugin docs #220

Closed
wants to merge 1 commit into from
Closed

Conversation

arlyon
Copy link

@arlyon arlyon commented May 22, 2023

LTO is not supported. I added a call-out for it.

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ❌ Failed (Inspect) May 22, 2023 2:58pm

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kwonoj
Copy link
Member

kwonoj commented May 22, 2023

This is a bug we're trying to fix, not sure if we call it as unsupported.

@@ -15,6 +15,10 @@ cargo build-wasm32 --release // build wasm32-unknown-unknown target binary

It will create `target/wasm32-wasi/release/your_plugin_name.wasm` or `target/wasm32-unknown-unknown/release/your_plugin_name.wasm`, depending on your config.

<Callout emoji="ℹ️">
Currently link-time optimisation is not supported, and plugins compiled with `lto` will likely panic on execution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

@arlyon
Copy link
Author

arlyon commented May 22, 2023

I don't mind the specific wording (or closing this altogether..)

@arlyon arlyon closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants