Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

swc-shell images issue #67

Closed
HaveF opened this issue Oct 12, 2013 · 6 comments
Closed

swc-shell images issue #67

HaveF opened this issue Oct 12, 2013 · 6 comments
Assignees

Comments

@HaveF
Copy link
Contributor

HaveF commented Oct 12, 2013

  1. In swc-shell, some images are broken(Like Figure 4), I can send a PR later.
  2. But it seems some images are lost? Like Figure 9: The Nano Editor. Can not find in the bc repo. But I find them at guide repo. What can I do?
@ahmadia
Copy link
Contributor

ahmadia commented Oct 12, 2013

Thanks for reporting this, it looks like all the figures indeed are missing. I suspect the content is there but the links are broken in some way. I'll take a look.

@HaveF
Copy link
Contributor Author

HaveF commented Oct 12, 2013

Some of the contents are there, but some are at guide repo. You can see here.

@ahmadia
Copy link
Contributor

ahmadia commented Oct 12, 2013

Feel free to copy them over from guide into the PR, I'm pretty sure that's the original provenance.

@gvwilson
Copy link
Contributor

On 2013-10-11 11:48 PM, HaveF wrote:

In swc-shell
<http://swcarpentry.github.io/bc/lessons/swc-shell/tutorial.html>,
some images are broken(Like |Figure 4|), I can send a PR later.
But it seems some images are lost? Like |Figure 9: The Nano
Editor|. Can not find in the bc repo. But I find them at guide
repo <https://github.com/swcarpentry/guide/tree/master/shell>.
What can I do?

Many figures haven't been done yet (because I hate doing figures).
Action on me...

@ghost ghost assigned gvwilson Oct 13, 2013
@ahmadia
Copy link
Contributor

ahmadia commented Oct 13, 2013

Okay, I've assigned @gvwilson on this.

@ahmadia
Copy link
Contributor

ahmadia commented Oct 17, 2013

As @r-gaia-cs mentions in #81, all 18 Figures are now present and accounted for thanks to @HaveF's work in #68. We're still figuring out the best place to put them, but that discussion is happening in #81, so we'll close this one as resolved.

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants