-
-
Notifications
You must be signed in to change notification settings - Fork 383
Added example multi-line indented block #105
Conversation
@@ -322,7 +322,7 @@ | |||
"elif x == 2:\n", | |||
" print \"x is two\"\n", | |||
"else:\n", | |||
" print \"x is positive and greater than 2\"" | |||
" print \"x is positive and is not 0, 1, or 2\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is not equal to 0, 1, or 2?
Since we're being very careful here :)
@wltrimbl Nice PR. After you take a look in the comments I will review it again. |
I addressed all the minor points except the spelling of the plural of index and line wrapping convention, and have revised the line that implied that indented blocks were only for conditionals. Thanks all for the editing comments. |
@@ -291,7 +291,7 @@ | |||
"cell_type": "markdown", | |||
"metadata": {}, | |||
"source": [ | |||
"While there must be one if statetment, and there may be at most one else statement, there maybe as many elif statements as are desired.\n", | |||
"While there must be one if statement, and there may be at most one else statement, there maybe as many elif statements as are desired.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you forget something in "there maybe as many elif statements"?
@wltrimbl - apologies, but this needs to be rebased :( |
Rebase attempted: |
I vote for merging this, then incorporating it into |
I'd suggest we review the rebased material before merging. |
Scrutinzing this line-by-line, I find that I have spell-corrected (which is to say, corrupted) one of the instructor's names. There are also one or a few instances of |
Errr, we have a style guide? |
To summarize:
This PR does not introduce new content (TM) |
By style guide I mean style guidance: the notes in PR #71 on consistency between using Any objections to merging? |
Conflicts: lessons/thw-python/flow-control/python_flow_control.ipynb lessons/thw-python/vars-types/variables.ipynb
This can't be merged automatically, I'm bringing it in by hand. |
Additionally, added sentences introducing the loops through
zip()
anditer()
This responds to student confusion about where the if statement ends.