Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

shell: Rename the new-style lessons from 'bash' to 'shell' #222

Merged
merged 1 commit into from
Feb 2, 2014

Conversation

wking
Copy link
Contributor

@wking wking commented Jan 9, 2014

This is mostly about utilities with a few references to the basic POSIX shell,
and hardly at all about Bash itself (as distinct from POSIX shells more
generally). 'shell' is also consistent with the existing:

  • _includes/guide-shell
  • lessons/ref/shell.html
  • lessons/swc-shell
  • lessons/thw-shell

As requested in #221 1. This conflicts with some of the #221
changes though, so either this PR or that one will have to be rebased
(or otherwise integrated) with the other.

@ahmadia
Copy link
Contributor

ahmadia commented Jan 9, 2014

Thanks @wking. In general, I am neutral on this one. I'm not sure shell is that much better than bash for describing this set of lessons. Happy to let @gvwilson make the call on this, unless somebody else has strong feelings for or against.

@wking
Copy link
Contributor Author

wking commented Jan 9, 2014

On Thu, Jan 09, 2014 at 10:23:51AM -0800, Aron Ahmadia wrote:

I'm not sure shell is that much better than bash for describing
this set of lessons.

If we weren't looking for a short-and-sweet directory name, I'd prefer
“Shell & Utilities” which the POSIX folks presumably put some thought
into 1 ;). These lessons are mainly about generic POSIX concepts
(filesystem paths 2, basic utilities 3). However, I think calling
the directory 'posix' would confuse people :p. 'shell' is both
familiar, roughly accurate (because we use the shell to teach the
lessons), and not over-specific. If you want to talk about
associative arrays (/shell/hash/intermediate? ;), than we're talking
Bash instead of POSIX ;).

@gvwilson
Copy link
Contributor

gvwilson commented Jan 9, 2014

Let's call it 'shell' and move on :-)

@ethanwhite
Copy link
Contributor

+1

@ahmadia
Copy link
Contributor

ahmadia commented Feb 1, 2014

@wking - Since this is going to be a slightly painful rename, I suggest we do it as soon as possible. Want to redo this PR and we can start fixing other PRs that touch this material?

@wking
Copy link
Contributor Author

wking commented Feb 1, 2014

On Sat, Feb 01, 2014 at 12:23:36PM -0800, Aron Ahmadia wrote:

@wking - Since this is going to be a slightly painful rename, I
suggest we do it as soon as possible. Want to redo this PR and we
can start fixing other PRs that touch this material?

Rebase and add the goo* stuff from #254?

This is mostly about utilities with a few references to the basic
POSIX shell, and hardly at all about Bash itself (as distinct from
POSIX shells more generally).  'shell' is also consistent with the
existing:

* _includes/guide-shell
* lessons/ref/shell.html
* lessons/swc-shell
* lessons/thw-shell

If we weren't looking for a short-and-sweet directory name, I'd prefer
"Shell & Utilities" which the POSIX folks presumably put some thought
into [1] ;).  These lessons are mainly about generic POSIX concepts
(filesystem paths [2], basic utilities [3]).  However, I think calling
the directory 'posix' would confuse people :p.  'shell' is both
familiar, roughly accurate (because we use the shell to teach the
lessons), and not over-specific.  If you want to talk about
associative arrays (/shell/hash/intermediate? ;), than we're talking
Bash instead of POSIX ;).

[1]: http://pubs.opengroup.org/onlinepubs/9699919799/idx/xcu.html
[2]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_12
[3]: http://pubs.opengroup.org/onlinepubs/9699919799/idx/utilities.html
@wking
Copy link
Contributor Author

wking commented Feb 1, 2014

On Sat, Feb 01, 2014 at 12:43:15PM -0800, W. Trevor King wrote:

Rebase and add the goo* stuff from #254?

Done.

@ahmadia
Copy link
Contributor

ahmadia commented Feb 1, 2014

That sounds good to me. Unless I hear any klaxons I'll merge it in
tomorrow.

A

On Saturday, February 1, 2014, W. Trevor King notifications@github.com
wrote:

On Sat, Feb 01, 2014 at 12:23:36PM -0800, Aron Ahmadia wrote:

@wking - Since this is going to be a slightly painful rename, I
suggest we do it as soon as possible. Want to redo this PR and we
can start fixing other PRs that touch this material?

Rebase and add the goo* stuff from #254?

Reply to this email directly or view it on GitHubhttps://github.com//pull/222#issuecomment-33882877
.

ahmadia added a commit that referenced this pull request Feb 2, 2014
shell: Rename the new-style lessons from 'bash' to 'shell'
@ahmadia ahmadia merged commit 1bd8ae5 into swcarpentry:master Feb 2, 2014
@wking wking deleted the rename-bash-to-shell branch February 2, 2014 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants