-
-
Notifications
You must be signed in to change notification settings - Fork 383
Python tutor links + consider removing some material #60
Conversation
…om following the stack in a more complex example
"but when Python tries to get the value of `middle`,\n", | ||
"it discovers that it doesn't exist any longer\n", | ||
"and reports an error.\n", | ||
"(The error appears first because the Python interpreter gives higher priority to error messages than \"normal\" output.)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? I thought this sort of thing occurred because stdout is buffered and stderr is not?
There's another bug in NB 1,
|
In NB 2:
|
@juliangarcia - Thanks for the PR. This looks good in general, and I think the only bugs I've found were there before you tackled this. Do you mind adding a little more information to the top of the pull request summarizing your changes and why you're making them? This is an aesthetic thing, but you should try to follow the rules for formatting Git commit messages if you'd like them to show up properly. Also, could you make the Python Tutor link more explicit? Instead of just using [here] in your link, perhaps [at the Online Python Tutor] or similar? |
Also, lets modify the |
I understand that changing the temp variables to temp_c and temp_k will be dealt with in a different PR. Other than that I have addressed the suggested changes. Thanks! |
Looks good. I'm +1 on merging this, but I'll leave it open for another day in case anybody else has any comments or feedback. And good job on the commit message :) |
Looks good to me too. @juliangarcia Nice job. |
Awesome job @juliangarcia. Thanks for the review @r-gaia-cs. |
Python tutor links + consider removing some material
I added links to the python online tutor in order to have a more dynamic picture of the stacks in the functions notebook.
This is part of an exercise for the SWC training, round 6.