Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

Add portuguese translation of index.html #630

Closed
wants to merge 1 commit into from

Conversation

rgaiacs
Copy link

@rgaiacs rgaiacs commented Jul 26, 2014

This implement the first suggestion of #602 because index.html uses _includes/setup.html and I didn't find one way to make translations/pt/index.html uses translations/pt/_includes/setup.html or something similar.

Long Description

  • Replace index.html with index-en.html
  • Create index.html with redirect to index-en.html
  • Create index-pt.html
  • Update documentation
  • Replace _includes/setup.html with _includes/setup-en.html
  • Create _includes/setup-pt.html

@rgaiacs
Copy link
Author

rgaiacs commented Jul 27, 2014

@gvwilson Any comments?

@dpshelio
Copy link

From the Spanish translation team we haven't got that far yet... we have started with the content. Next step is going to work out in the integration with the rest. I was thinking in allow all the languages in the same place, without the instructor having to change anything, just by the browser to choose the language by itself (or a dropdown menu). Of course, that needs a bit of thought to have it all integrated.

As you mentioned in #602 this will fill the root directories with a lot of files.
Would the _includes/setup.html problem would be easier to solve if we would have an en translation directory? and then the file loaded would be: translation/??/_includes/setup.html?

@rgaiacs
Copy link
Author

rgaiacs commented Jul 28, 2014

From the Spanish translation team we haven't got that far yet...

This PR exists only because of a couple of bootcamps in Brazil and I will hate
that anyone have to translate from scratch our index.html and setup.html in the
future.

Would the _includes/setup.html problem would be easier to solve if we would
have an en translation directory? and then the file loaded would be:
translation/??/_includes/setup.html?

The problem is that the include directive of Jekyll/Liquid only work with
files at _includes and not with foo/_includes. We could use symbolics links
from _includes/setup-XX.html to translation/XX/_includes/setup.html but this
will not reduce the number of files at _includes and add the trouble that
Git didn't handle symbolics links very well.

@gvwilson
Copy link
Contributor

I suggest closing this one and re-thinking after #759 lands - we will need a strategy for non-English lesson translations in general.

@rgaiacs
Copy link
Author

rgaiacs commented Sep 29, 2014

I agree with @gvwilson

I suggest closing this one and re-thinking after #759 lands - we will need a strategy for non-English lesson translations in general.

@rgaiacs rgaiacs closed this Sep 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants