Skip to content
This repository has been archived by the owner on Jan 3, 2018. It is now read-only.

Fix link to git pro book #183

Merged
merged 2 commits into from
Feb 22, 2015

Conversation

iglpdc
Copy link

@iglpdc iglpdc commented Feb 22, 2015

The link to Chacon's book was broken. This fixes it.

gvwilson pushed a commit that referenced this pull request Feb 22, 2015
@gvwilson gvwilson merged commit 42f23aa into swcarpentry:gh-pages Feb 22, 2015
@jdblischak
Copy link
Contributor

This fix was already merged into the core branch. See PR #179 (I had originally submitted directly to gh-pages in PR #178, but was instructed to send it to core). What is the process for contributing to this repo? Are we supposed to send PRs against core or gh-pages?

Also, why was the actual URL changed? I think Chapter 6.2, which explains the GitHub Flow, is a better place to send contributors than Chapter 5.2, which covers more complex details.

@iglpdc
Copy link
Author

iglpdc commented Feb 22, 2015

Yes, you're right @jdblischak. I wasn't aware of the core branch. I agree that we need guidelines on how to contribute to this repo: it doesn't say anywhere that we have a core branch, so it's easy to assume that PRs go against gh-pages as with the other repos.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants