Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lesson template and HTML #102

Merged
merged 28 commits into from Apr 27, 2015
Merged

Conversation

rgaiacs
Copy link
Contributor

@rgaiacs rgaiacs commented Apr 25, 2015

Ready to merge.

fmichonneau and others added 28 commits March 23, 2015 22:05
the class removed are unused as we take advantage of classes provided by
Bootstrap instead.
Downstream lesson maintainers are supposed to adapt this to point at
their repository's issues [1], so use a reference name that works for
both the lesson-template and downstream repositories.  That way they
only have to update the referenced URL and can leave the reference
name alone.

[1]: swcarpentry/DEPRECATED-lesson-template#195 (comment)
…for-contributing-issues

CONTRIBUTING.md: Use a generic reference name for the issues link
This avoids things like:

  ~$ cat tools/validation_helpers.py
  ...
          return self.is_block(ast_node) and has_heading~$

with your next prompt way over to the right ;).
tools: Add trailing newlines to files that were missing them
(even though the contents are not validated)
Ignore conduct.md and contributing.md. No, really.
Remove logger name (root) from console messages
Because we're going to be storing maintainer information locally in
the README.md [1].

[1]: swcarpentry/DEPRECATED-lesson-template#195 (comment)
CONTRIBUTING.md: Remove the maintainer references
Add article tag as wrap for lesson content
Figures should be centered
and not overflow the screen.
Pandoc had some changes in the last versions.
Having a variable for Pandoc will help
maintainers to handle different versions of Pandoc.
Thanks to ocefpaf for request that.
@iglpdc
Copy link
Contributor

iglpdc commented Apr 25, 2015

Thanks @r-gaia-cs. I just merged #97, could you rebase this PR?

@rgaiacs
Copy link
Contributor Author

rgaiacs commented Apr 26, 2015

@iglpdc Rebased.

@iglpdc
Copy link
Contributor

iglpdc commented Apr 27, 2015

Thanks @r-gaia-cs. I'm merging.

iglpdc added a commit that referenced this pull request Apr 27, 2015
Update lesson template and HTML
@iglpdc iglpdc merged commit 738bb13 into swcarpentry:gh-pages Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants