-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split 06-collab in two different topics #116
Conversation
b58b62a
to
d375c93
Compare
This is ready to review. Can someone take a look? |
+1, good split. |
Agreed, split seems sensible, since remotes are useful even when your collaborator is yourself. |
Conflicts: 06-collab.html
d375c93
to
74eaf7b
Compare
Split 06-collab in two different topics
> If you're working through this lesson on your own, you can carry on by opening | ||
> a second terminal window, and switching to another directory (e.g. `/tmp`). | ||
> This window will represent your partner, working on another computer. You | ||
> won't need to give anyone access on GitHub, because both 'partners' are you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest "both partners are you, using your Github login" to make it clearer what is meant here. Maybe also put this after talking about "giving the other person access" below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, @swaldman3, I agree in doing the change in the callout. This PR is merged already, so I'll have to make a separate one from scratch. Do you wanna do the PR yourself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to, but it won't be today. If you're wanting to get it wrapped up, please go ahead and do it :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
El 11/05/2015, a las 10:51, Simon Waldman notifications@github.com escribió:
Happy to, but it won't be today. If you're wanting to get it wrapped up, please go ahead and do it :-)
Good, I'll leave to you then, so you get credit for it.
lesson.scss: 2em left padding for lists
Split 06-collab in two different topics
This is a fix to #113, if we finally decide to do it.
I've chosen "Remotes In Github" as the name for the new topic. Other suggestions are welcome.
The rest is just renaming the files, and moving things around.