Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Open Science" and "Citation" notes #600

Open
wants to merge 1 commit into
base: gh-pages
from

Conversation

Projects
None yet
2 participants
@railyards
Copy link

commented Mar 8, 2019

Add instructor notes for Open Science and Citation.

These two sections were empty. The notes aim to help the instructor now why it is important to teach this content.

@munkm
Copy link
Collaborator

left a comment

Hi @railyards! Thank you so much for the PR improving the instructor guide, especially for these later lessons. I really like what you've added about open science, including the comment suggesting instructors include some personal examples.

I think that the citation lesson sentence could be improved by either mentioning how citations relate to licensing, or, alternatively, mentioning that it's beneficial to make one's code easily citable by including citation files like the ones that are mentioned in the lesson. Would you mind updating your PR to reflect this?

@@ -274,6 +281,8 @@ their breath after what is often a frustrating couple of hours.

## [Citation]({{ page.root }}/12-citation/)

We teach about citation because it is important to give learners the tools to respect the licensing chosen for the code.

This comment has been minimized.

Copy link
@munkm

munkm Mar 8, 2019

Collaborator

I think mentioning licensing here (especially because it comes right after the licensing lesson) is a little confusing. I think it could be clearer by talking about how licensing relates to citations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.