-
-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor language simplification #69
Conversation
+1 to merge. |
On Sat, Mar 14, 2015 at 12:59:33PM -0700, Ethan White wrote:
Looks good to me. |
On Sat, Mar 14, 2015 at 04:01:02PM -0700, W. Trevor King wrote:
Actually, we may want to keep the “as a commit” qualifier, since Git $ git init Initial commit Changes to be committed:
Changes not staged for commit:
$ git checkout -- mars.txt It's just that without a commit, doing something like checking out So I'd suggest: … but it hasn't recorded these changes as a commit yet. |
Thanks @ethanwhite ! I agree with @wking that keeping "as commit" would be clearer: "... these changes as a commit yet". |
@ethanwhite: I merged the big reorg PR #58, so please refactor the change against that new file. |
Language like "do so" and "for posterity" may be confusing for non-native English speakers. This makes this language more straight forward.
c37a12e
to
fc197f3
Compare
Language like "do so" and "for posterity" may be confusing for non-native
English speakers. This makes this language more straight forward.
This PR is currently missing updated html because until #68 goes in the diff shows far more change that has actually happened. I'll be happy to add the html changes after #68 is merged.