-
-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve commit messages in 01-backup #70
Improve commit messages in 01-backup #70
Conversation
+1 to merge. |
On Sat, Mar 14, 2015 at 01:06:49PM -0700, Ethan White wrote:
This change:
is in the content of mars.txt, not the commit message. You take “Thoughts about the climate” to “Add discussion of Mars' Regardless of the chosen climate commit message, I think this change
The maintainers are supposed to handle updating the HTML anyway, to |
Yes, we don't need to change the contents of the file. @ethanwhite, could you fix that and then I'll merge? By the way, I see that we don't give any explanation on how to write a commit message. Without going into much details, I think one good explanatory sentence (together with an entry in the lesson glossary) would be nice. I'm opening a new issue with this. |
@ethanwhite: I merged the big reorg PR #58, so please refactor the change against that new file. |
We should model good commit message style as best as possible. This updates the commit messages to make them a little better/more standard.
9d0320b
to
f5009ba
Compare
Thanks for the great review @wking. I had accidentally find and replaced the wrong text for the 'moons' commit - thanks for catching that. I have now:
|
f5009ba looks good to me :).
|
Improve commit messages in 01-backup
Add Unit Test target to Makefile
Improve commit messages in 01-backup
We probably don't want to get into the details of good commit message style
in this lesson, but we should try to model it as best as possible. This updates
the commit messages to make them a little better/more standard.
This PR is currently missing updated html because until #68 goes in the diff shows far more change that have actually happened. I'll be happy to add the html changes after #68 is merged.