Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing period from commit message #901

Merged
merged 1 commit into from Apr 29, 2023

Conversation

wjp
Copy link
Contributor

@wjp wjp commented Nov 7, 2022

This makes the commit message consistent with the others in this lesson. It also follows the advice from
https://chris.beams.io/posts/git-commit/ , which is referred to as a guideline for commit messages.

This makes the commit message consistent with the others in this
lesson. It also follows the advice from
https://chris.beams.io/posts/git-commit/ , which is referred to as
a guideline for commit messages.
Copy link
Contributor

@kekoziar kekoziar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this, but with the following commentary: technically, this is the commit subject, which is often used alone - and abstractly - to describe the commit. If the commit subject or message has sentences, it should use proper punctuation. There is no need to restrict a commit to only N number of characters. And, while Chris Beams has been referred to on commit messages, there are other, more current, theories and suggestions on commit messages. The point is to have them be meaningful and useful. if punctuation allows that, then it should be included.

@kekoziar kekoziar merged commit 4174281 into swcarpentry:gh-pages Apr 29, 2023
zkamvar pushed a commit that referenced this pull request May 8, 2023
Remove trailing period from commit message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants