New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use language-make for syntax highlighting of source code #134

Open
gcapes opened this Issue May 17, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@gcapes
Collaborator

gcapes commented May 17, 2018

I tried this, but it displays a red box around some of the code - do you know why @rgaiacs?

image

@rgaiacs

This comment has been minimized.

Contributor

rgaiacs commented May 17, 2018

        python testzipf.py abyss.dat isles.dat last.dat > results.txt

has spaces at the begin of the line but Make requires a tab. If you fix this the red box is disappear.

@gcapes

This comment has been minimized.

Collaborator

gcapes commented May 18, 2018

Great, thanks!

@gcapes gcapes closed this May 18, 2018

@gcapes gcapes reopened this May 18, 2018

@gcapes

This comment has been minimized.

Collaborator

gcapes commented May 18, 2018

Thoughts on this @rgaiacs? The syntax is correct this time.
I could use . language-bash instead for this code block to avoid the red boxes, but that's not the correct language. This is from episode 6.

image

@rgaiacs

This comment has been minimized.

Contributor

rgaiacs commented May 18, 2018

The syntax is correct this time.

I get the felling that include isn't included in rouge's rules, https://github.com/jneen/rouge/blob/master/lib/rouge/lexers/make.rb

@gcapes

This comment has been minimized.

Collaborator

gcapes commented May 18, 2018

What would you recommend? Just leave the Make lesson using the new language-make option and submit an issue to rouge?

@rgaiacs

This comment has been minimized.

Contributor

rgaiacs commented May 18, 2018

Just leave the Make lesson using the new language-make option

You could use language-shell for that chunk.

submit an issue to rouge?

That would be great.

@gcapes

This comment has been minimized.

Collaborator

gcapes commented May 18, 2018

There's too many instances (IMO) where this appears for language-shell to be a satisfactory solution - the syntax highlighting of the makefile would change between instances, so I think I'll use the new highlighting and put up with the red boxes until there is a fix from rouge.

Example from episode 7
image

@gcapes

This comment has been minimized.

Collaborator

gcapes commented May 18, 2018

Issue now open at jneen/rouge#913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment