Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding for loop exercise to _extras/extra_exercises.md #567

Merged
merged 6 commits into from Mar 1, 2019
Merged

adding for loop exercise to _extras/extra_exercises.md #567

merged 6 commits into from Mar 1, 2019

Conversation

nathaliagg
Copy link
Contributor

I added lines 293-318, which were deleted from the 02-lists lesson, to the end of _extras/extra_exercises.md.

@maxim-belkin maxim-belkin added type:enhancement Propose enhancement to the lesson Lists - Loops labels Aug 14, 2018
@maxim-belkin
Copy link
Contributor

Wow, I missed this pull request completely! My apologies! Going to look into it now.

@maxim-belkin maxim-belkin added this to Needs review in Lists-Loops Aug 14, 2018
@maxim-belkin maxim-belkin self-requested a review August 14, 2018 15:33
@maxim-belkin
Copy link
Contributor

This PR has all the changes introduced in #563 and addresses my request-for-changes, so I closed #563.

_episodes/02-lists.md Outdated Show resolved Hide resolved
@nathaliagg
Copy link
Contributor Author

nathaliagg commented Nov 14, 2018 via email

Added some context to learning lists. Too long maybe?
@maxim-belkin
Copy link
Contributor

maxim-belkin commented Nov 15, 2018

Thanks, @ngrafgr! The changes look good to me (a have a few minor stylistics comments but I'll keep them to myself to speed up the merge :))!
I'd like to invite @ldko to review the changes... Lauren, this PR is part of an ongoing effort to switch the order of the episodes on lists and for loops, so these changes will not appear in the episodes immediately upon the merge.

Lists-Loops automation moved this from Needs review to Reviewer approved Nov 15, 2018

Our goal with this Python lesson is to automate our analysis.
Simply, we will write one code that will analyze all files,
instead of changing the file name and running the code eleven more times.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great how the episode has been changed here to reference the overall goal of the lesson to analyze all the inflammation data in an automated fashion. I think the phrase "one code" could be confusing and the wording could benefit from specifying that the files are the inflammation data files. Also, I think the "automated code" phrase may be used more times than needed here. @ngrafgr and @maxim-belkin sorry, I am about to board a plane and will have limited Internet access the next couple days, so please don't wait on me for further review here. I think the design of these changes are good--just needs a bit of word tweaking, so perhaps @maxim-belkin can make further suggestions.

@maxim-belkin
Copy link
Contributor

Thanks, @annefou!

Thanks, @ldko! I'll make some changes and merge it after that.

@maxim-belkin maxim-belkin merged commit ba96f26 into swcarpentry:lists-loops Mar 1, 2019
Lists-Loops automation moved this from Reviewer approved to Done Mar 1, 2019
@maxim-belkin
Copy link
Contributor

Thank you, @ngrafgr! Thank you, @ldko! Thank you, @annefou!

maxim-belkin pushed a commit that referenced this pull request Apr 6, 2021
maxim-belkin pushed a commit to maxim-belkin/python-novice-inflammation that referenced this pull request May 15, 2021
…dencies

bin/dependencies.R: handle 'no packages were specified' error
zkamvar pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
No open projects
Lists-Loops
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants