New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding for loop exercise to _extras/extra_exercises.md #567
Conversation
Wow, I missed this pull request completely! My apologies! Going to look into it now. |
@maxim-belkin, I will get to this! I apologize for the delay.
On Tue, Oct 16, 2018 at 6:50 PM Maxim Belkin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In _episodes/02-lists.md
<#567 (comment)>
:
> @@ -20,8 +20,7 @@ list[2:9]), in the same way as strings and arrays."
- "Strings are immutable (i.e., the characters in them cannot be changed)."
---
-Just as a `for` loop is a way to do operations many times,
-a list is a way to store many values.
+A list is a way to store many values.
A gentle ping, @ngrafgr <https://github.com/ngrafgr>!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#567 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AOQXIR-eZOvLtkEeQBiUvQdjr2Qfy0fUks5ulmKYgaJpZM4VT4pG>
.
--
Nathalia Graf Grachet
Graduate Research Assistant
Department of Entomology & Plant Pathology
Oklahoma State University
127 Noble Research Center
Stillwater, OK 74078
(405) 334-1746
ngrafgr@okstate.edu <ngrafgr@okstate.edu>
|
Added some context to learning lists. Too long maybe?
Thanks, @ngrafgr! The changes look good to me (a have a few minor stylistics comments but I'll keep them to myself to speed up the merge :))! |
_episodes/02-lists.md
Outdated
|
||
Our goal with this Python lesson is to automate our analysis. | ||
Simply, we will write one code that will analyze all files, | ||
instead of changing the file name and running the code eleven more times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is great how the episode has been changed here to reference the overall goal of the lesson to analyze all the inflammation data in an automated fashion. I think the phrase "one code" could be confusing and the wording could benefit from specifying that the files are the inflammation data files. Also, I think the "automated code" phrase may be used more times than needed here. @ngrafgr and @maxim-belkin sorry, I am about to board a plane and will have limited Internet access the next couple days, so please don't wait on me for further review here. I think the design of these changes are good--just needs a bit of word tweaking, so perhaps @maxim-belkin can make further suggestions.
…dencies bin/dependencies.R: handle 'no packages were specified' error
I added lines 293-318, which were deleted from the 02-lists lesson, to the end of _extras/extra_exercises.md.