New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding for loop exercise to _extras/extra_exercises.md #567

Open
wants to merge 4 commits into
base: lists-loops
from

Conversation

4 participants
@ngrafgr

ngrafgr commented Jul 18, 2018

I added lines 293-318, which were deleted from the 02-lists lesson, to the end of _extras/extra_exercises.md.

ngrafgr added some commits Jul 13, 2018

@maxim-belkin

This comment has been minimized.

Collaborator

maxim-belkin commented Aug 14, 2018

Wow, I missed this pull request completely! My apologies! Going to look into it now.

@maxim-belkin maxim-belkin added this to Needs review in Lists-Loops Aug 14, 2018

@maxim-belkin maxim-belkin self-requested a review Aug 14, 2018

@maxim-belkin

This comment has been minimized.

Collaborator

maxim-belkin commented Aug 14, 2018

This PR has all the changes introduced in #563 and addresses my request-for-changes, so I closed #563.

Show resolved Hide resolved _episodes/02-lists.md Outdated
@ngrafgr

This comment has been minimized.

ngrafgr commented Nov 14, 2018

better intro to 02-lists.md
Added some context to learning lists. Too long maybe?
@maxim-belkin

This comment has been minimized.

Collaborator

maxim-belkin commented Nov 15, 2018

Thanks, @ngrafgr! The changes look good to me (a have a few minor stylistics comments but I'll keep them to myself to speed up the merge :))!
I'd like to invite @ldko to review the changes... Lauren, this PR is part of an ongoing effort to switch the order of the episodes on lists and for loops, so these changes will not appear in the episodes immediately upon the merge.

Lists-Loops automation moved this from Needs review to Reviewer approved Nov 15, 2018

Our goal with this Python lesson is to automate our analysis.
Simply, we will write one code that will analyze all files,
instead of changing the file name and running the code eleven more times.

This comment has been minimized.

@ldko

ldko Nov 16, 2018

Contributor

I think this is great how the episode has been changed here to reference the overall goal of the lesson to analyze all the inflammation data in an automated fashion. I think the phrase "one code" could be confusing and the wording could benefit from specifying that the files are the inflammation data files. Also, I think the "automated code" phrase may be used more times than needed here. @ngrafgr and @maxim-belkin sorry, I am about to board a plane and will have limited Internet access the next couple days, so please don't wait on me for further review here. I think the design of these changes are good--just needs a bit of word tweaking, so perhaps @maxim-belkin can make further suggestions.

@maxim-belkin

This comment has been minimized.

Collaborator

maxim-belkin commented Nov 17, 2018

Thanks, @annefou!

Thanks, @ldko! I'll make some changes and merge it after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment