Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

01-numpy.md: Loading data: update introductory text #657

Merged
merged 1 commit into from Feb 1, 2020

Conversation

maxim-belkin
Copy link
Contributor

Update introductory text in "Loading data into Python".

Reasons:

  • justify the need to load data
  • remove access a library as it seems rather vague
  • add a comma before which stands for
  • change you want to do fancy things with numbers to you want to do fancy things with lots of numbers

@maxim-belkin
Copy link
Contributor Author

ping, @annefou

Copy link
Contributor

@ldko ldko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxim-belkin I am in favor of this text change to help clarify about importing a library and when to use NumPy. I approve pending rebase. Thanks!

@maxim-belkin
Copy link
Contributor Author

Rebased. Thank you for reviewing this, Lauren.

Copy link

@annefou annefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thank you.

@maxim-belkin maxim-belkin merged commit 7836d4f into swcarpentry:gh-pages Feb 1, 2020
@maxim-belkin maxim-belkin deleted the 01-intro-update branch February 1, 2020 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants