provide brief inline variable type descriptions #941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldko
reviewed
Jun 24, 2021
| * strings. | ||
| * integer numbers (numbers without decimals) | ||
| * floating point numbers (numbers with decimals), and | ||
| * strings (text data). |
There was a problem hiding this comment.
I think this kind of addition could be helpful. I suggest changing the integer description to "(whole numbers)". Also, we could link the text for each type to the entries in the glossary which are:
https://swcarpentry.github.io/python-novice-inflammation/reference.html#integer
https://swcarpentry.github.io/python-novice-inflammation/reference.html#floating-point-number
https://swcarpentry.github.io/python-novice-inflammation/reference.html#string
What do you think about adding the descriptions @maxim-belkin ?
There was a problem hiding this comment.
What do you think about adding the descriptions @maxim-belkin ?
I like it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I thought it could be helpful to add brief inline variable type descriptions when first introducing attendees to different data types. 馃帀