New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
04-data-structures-part1 doesn't mention operations with matrices #112
Comments
Good idea @rgaiacs. I added this issue to the milestone for the Bug BBQ and hopefully someone will open a PR to resolve it. |
This content really doesn't fit in 04-data-structures. Matrix multiplication is covered in 09-vectorisation. I suggest we close this issue. |
Since operations of vectors are not discussed in 04-data-structures, I agree with @tomwright01 . However, why does the vectorisation lesson come so far after data structures? It seems like it should be the next lesson. |
Agreed on matrix operations. I would move the Matrix section above the data.frame, though, because data.frames are more general. What do you think? |
Though if someone is completely new the current order may work well. You can introduce data frames as a general case. Then matrices as something less general: a table in which everything has to be the same type. Under the hood they are implemented very differently, but to the user that may be the easiest way to initially understand the difference. |
It sounds like there is support for leaving it as is, so I'd like to close this issue unless anyone has strong objections? Currently, the content is covered in 09-vectorization, so the question as I understand it is about the proper placement of that content relative to content about data frames. |
I don't think there is any problem moving 09-vectorisation. The question is where to? Obviously after 04-data structures, but we don't want to push creating graphs back too far. I suggest after "subsetting data" but then swap "control flow" and "creating graphics". The final order would then be:
Feel free to close this though. Otherwise I can probably make these changes this afternoon. |
Oh, no, sorry, my point was not to move 09. Was to move the paragraph about matrices that is already within 04 above data frames. I see no reason to have it after data frames in that chapter: it does not use any of the concepts introduced for data frames, but relies only on vectors... I still think chapter 04 may take advantage of a reflowing. |
Closing b/c of no activity and support for leaving order as-is. |
One more demotivator
When you say matrices I think in linear algebra. Right after you teach me how I can create one matrix in R I will want to know how I can execute linear algebra operations in R, e.g. sum and multiplication. But
I think this should go into one challenge.
The text was updated successfully, but these errors were encountered: