Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MAKEFILE to check knitr version #42

Closed
sritchie73 opened this issue Jun 5, 2015 · 4 comments
Closed

Update MAKEFILE to check knitr version #42

sritchie73 opened this issue Jun 5, 2015 · 4 comments

Comments

@sritchie73
Copy link
Contributor

make preview will only compile the code blocks in the challenges and callouts correctly if knitr is version 1.10.12 or higher. Currently, this requires installing from github: (devtools::install_github("yihui/knitr")).

I've written an R script that will throw an error if the knitr version is too low (tools/check_knitr_version.R) in Pull Request #41 , but I wasn't able to successfully incorporate it into the Makefile to prevent future contributors from clobbering the code block rendering.

@sritchie73
Copy link
Contributor Author

Thoughts on this approach @jdblischak ? Does r-novice-inflammation have code blocks in any of its challenges?

@aammd
Copy link
Contributor

aammd commented Jun 8, 2015

Moving this discussion over to the lesson-template repo. Hopefully we will be able to change the One True Makefile to support this behaviour, and then I will include those changes here.

@jdblischak
Copy link
Contributor

I think this issue can be closed now that the following PR has been incorporated into the lesson-template:

swcarpentry/DEPRECATED-lesson-template#271

@naupaka
Copy link
Member

naupaka commented Nov 19, 2015

Yup. Good call.

@naupaka naupaka closed this as completed Nov 19, 2015
rgaiacs pushed a commit to rgaiacs/swc-r-novice-gapminder that referenced this issue May 6, 2017
…osition

fixing transposition of link in markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants