Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change theme code in ggplot episode from removing axis labels to simply rotating them #484

Closed
naupaka opened this issue Mar 10, 2019 · 3 comments
Closed

Change theme code in ggplot episode from removing axis labels to simply rotating them #484

naupaka opened this issue Mar 10, 2019 · 3 comments
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors type:bug Code included in the lesson needs to be fixed

Comments

@naupaka
Copy link
Member

naupaka commented Mar 10, 2019

I don't think we should ever encourage folks to make plots without x axis labels, which is what happens in this example.

r-novice-gapminder/_episodes_rmd/08-plot-ggplot2.Rmd

Line 352 in f3d5c95

theme(axis.text.x=element_blank(), axis.ticks.x=element_blank())

I propose that we replace the code to remove labels and tick marks

theme(axis.text.x=element_blank(), axis.ticks.x=element_blank())

with code to make the labels vertical (so they don't overlap)

theme(axis.text.x = element_text(angle = 90, hjust = 1))
@naupaka naupaka added help wanted Looking for Contributors type:bug Code included in the lesson needs to be fixed good first issue Good issue for first-time contributors labels Mar 10, 2019
ksamuk added a commit to ksamuk/r-novice-gapminder that referenced this issue Apr 5, 2019
@ksamuk
Change blank axis in 08-plot-ggplot to rotated form
a29e76a 
This addresses the issue here swcarpentry#484
@ksamuk ksamuk mentioned this issue Apr 5, 2019
Closed
@ksamuk
Copy link
Contributor

ksamuk commented Apr 5, 2019 •
edited

Hi! I agree with this wholeheartedly and created a pull request to address this here. ksamuk#1 (comment)

Thanks!

@naupaka
Copy link
Member Author

naupaka commented Apr 5, 2019

@ksamuk thanks! Can you submit the PR against the master branch in this repository? It looks like the PR is on your fork.

@ksamuk ksamuk mentioned this issue Apr 5, 2019
Merged
@ksamuk
Copy link
Contributor

ksamuk commented Apr 5, 2019 •
edited

My bad, now redone here: #493, hope that's correct!

@naupaka naupaka closed this as completed Apr 5, 2019
fmichonneau pushed a commit that referenced this issue Nov 23, 2020
@maxim-belkin
Makefile: don't use /bin/bash shell (#484)
b12821e
zkamvar pushed a commit that referenced this issue May 3, 2023
@ksamuk
Change blank axis in 08-plot-ggplot to rotated form
e828749 
This addresses the issue here #484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good issue for first-time contributors help wanted Looking for Contributors type:bug Code included in the lesson needs to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naupaka @ksamuk