Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current release build broken - Rv4.0 incompatibilities? #633

Open
marklcrowe opened this issue May 8, 2020 · 4 comments
Open

Current release build broken - Rv4.0 incompatibilities? #633

marklcrowe opened this issue May 8, 2020 · 4 comments
Assignees
Labels
status:in progress type:bug

Comments

@marklcrowe
Copy link
Contributor

@marklcrowe marklcrowe commented May 8, 2020

Hi, there looks to have been bugs introduced in the most recently build of episode 05-data-structures-part2. Specifically, the last table of the "Adding columns and rows in data frames" section and the first two of "Removing rows" are broken in the final .md output (NAs where there should be data, data, where there should be NAs).

My guess is that it's a consequence of the build being performed with R4.0, with the switch to stringsAsFactors = FALSE on read.csv giving different dataframe structures and so unexpected outputs. And because it's a build issue rather than a code error, I can't lodge a pull request to try to fix it.

Are you able to roll back to a previous version of this .md file until the episode has been updated enough to be compatible with R 4.0 please? At the moment, it's wrong for all versions of R!

Thanks very much

Cheers, Mark


Thanks for contributing! If this contribution is for instructor training, please send an email to checkout@carpentries.org with a link to this contribution so we can record your progress. You’ve completed your contribution step for instructor checkout just by submitting this contribution.

If this issue is about a specific episode within a lesson, please provide its link or filename.

Please keep in mind that lesson maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact Kate Hertweck (k8hertweck@gmail.com).


@jcoliver
Copy link
Contributor

@jcoliver jcoliver commented May 8, 2020

Thanks, @marklcrowe . We're looking into this now.

@jcoliver
Copy link
Contributor

@jcoliver jcoliver commented May 20, 2020

This is indeed caused by the development of lesson materials for R versions < 4.0, while the Travis CI uses R 4.0 to build the lesson that is displayed. With the use of Travis CI, md files are no longer used for the display of lesson materials, so replacing the md files will not change what is displayed on the lesson site. The ideal options include revising the lesson material to (1) use all R 4.0, whereby the factor errors thrown by adding a new coat color go away and/or (2) add information about the varied behavior of read.csv between different versions of R.

@jcoliver jcoliver added status:wait type:bug labels Jun 23, 2020
@naupaka naupaka self-assigned this Sep 22, 2020
@naupaka naupaka added status:in progress and removed status:wait labels Sep 22, 2020
@jcoliver
Copy link
Contributor

@jcoliver jcoliver commented Feb 3, 2021

Stopgap PR in #684 for episodes 4 & 5, but longer term solution in the works.

@mlell
Copy link
Contributor

@mlell mlell commented Aug 17, 2021

@jcoliver This is a proposed solution, among other things: #737 : Get rid of factors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in progress type:bug
Projects
None yet
Development

No branches or pull requests

4 participants