New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove factors from 05-data-structures-part2.Rmd #829
Conversation
We removed the factors section of Data Structures Part 2 consistent with the changes made to Data Structure Part 1 which have already been merged.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-829 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-05-12 12:29:28 +0000 |
Thanks a lot for your contribution @hannaheow! It is great to have this episode consistent with the previous one in its use of character vectors instead of factors. I took the liberty of adding a few minor changes to the PR:
I also agree with you that it could be interesting to add a section about factors in a lesson about plotting. Would you mind opening a new issue about this? LGTM for merging (cc @skanwal or @naupaka for confirmation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hannaheow for your suggestions and inputs. It looks good to me.
Thanks again @matthieu-bruneaux for keeping up with the PRs.
Auto-generated via {sandpaper} Source : 274c1e4 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2023-05-16 21:41:28 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : d96d991 Branch : main Author : Naupaka Zimmerman <naupaka@gmail.com> Time : 2023-05-16 21:39:05 +0000 Message : Merge pull request #829 from hannaheow/patch-1
We removed the factors section of Data Structures Part 2 consistent with the changes made to Data Structure Part 1 which have already been merged. #737
We recommend adding a section about factors to a lesson about plotting.
This is related to Issue #633.
@sstevens2