Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove factors from 05-data-structures-part2.Rmd #829

Merged
merged 3 commits into from May 16, 2023

Conversation

hannaheow
Copy link
Contributor

We removed the factors section of Data Structures Part 2 consistent with the changes made to Data Structure Part 1 which have already been merged. #737

We recommend adding a section about factors to a lesson about plotting.

This is related to Issue #633.

@sstevens2

We removed the factors section of Data Structures Part 2 consistent with the changes made to Data Structure Part 1 which have already been merged.
@github-actions
Copy link

github-actions bot commented May 8, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-829

The following changes were observed in the rendered markdown documents:

 05-data-structures-part2.md | 290 ++++++++++----------------------------------
 md5sum.txt                  |   2 +-
 2 files changed, 63 insertions(+), 229 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-05-12 12:29:28 +0000

github-actions bot pushed a commit that referenced this pull request May 12, 2023
github-actions bot pushed a commit that referenced this pull request May 12, 2023
@matthieu-bruneaux
Copy link
Contributor

Thanks a lot for your contribution @hannaheow! It is great to have this episode consistent with the previous one in its use of character vectors instead of factors.

I took the liberty of adding a few minor changes to the PR:

  • removing mentions of removing NAs since we do not use na.omit() in this episode anymore
  • updating the note about removing several rows at once
  • updating the numbering of the challenges
  • replacing summary(gapminder$country) by summary(gapminder) to be consistent with the text (this was not related to a change you made in the PR)

I also agree with you that it could be interesting to add a section about factors in a lesson about plotting. Would you mind opening a new issue about this?

LGTM for merging (cc @skanwal or @naupaka for confirmation).

@skanwal skanwal self-requested a review May 14, 2023 23:27
Copy link
Contributor

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hannaheow for your suggestions and inputs. It looks good to me.
Thanks again @matthieu-bruneaux for keeping up with the PRs.

@naupaka naupaka merged commit d96d991 into swcarpentry:main May 16, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 16, 2023
Auto-generated via {sandpaper}
Source  : d96d991
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2023-05-16 21:39:05 +0000
Message : Merge pull request #829 from hannaheow/patch-1
github-actions bot pushed a commit that referenced this pull request May 16, 2023
Auto-generated via {sandpaper}
Source  : 274c1e4
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-05-16 21:41:28 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d96d991
Branch  : main
Author  : Naupaka Zimmerman <naupaka@gmail.com>
Time    : 2023-05-16 21:39:05 +0000
Message : Merge pull request #829 from hannaheow/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants