Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code that is not needed #873

Closed
SarithaKodikara opened this issue Nov 8, 2023 · 2 comments · Fixed by #877
Closed

Remove code that is not needed #873

SarithaKodikara opened this issue Nov 8, 2023 · 2 comments · Fixed by #877

Comments

@SarithaKodikara
Copy link
Contributor

How could the content be improved?

In the episode exploring data frames (https://swcarpentry.github.io/r-novice-gapminder/05-data-structures-part2.html), renaming row names is unnecessary as R re-names them sequentially. So, in the section 'Append to a data frame', the following code snippet can be removed.

rownames(cats) <- NULL
cats

Which part of the content does your suggestion apply to?

https://swcarpentry.github.io/r-novice-gapminder/05-data-structures-part2.html
@matthieu-bruneaux
Copy link
Contributor

Thank you for noticing this @SarithaKodikara!

If you would like to submit a PR addressing this, I would be happy to review and merge it.

@SarithaKodikara SarithaKodikara mentioned this issue Nov 21, 2023
Merged
@matthieu-bruneaux
Copy link
Contributor

Thank you for your PR and for helping us to keep the lesson up to date @SarithaKodikara!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unwanted R code SarithaKodikara/r-novice-gapminder
2 participants
@matthieu-bruneaux @SarithaKodikara