New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructor-training assignment #245
Conversation
Added an additional feature to the challenge, mainly to introduce reserved words as well as add descriptions to the solutions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the explanations take up more than a single line, you might consider making them into an unordered list to increase legibility. You might also want to have the variable names displayed in monospaced code style.
_episodes/01-rstudio-intro.md
Outdated
> > _age - We can only start variable names with letters or dots not followed by a number. | ||
> > min-length - This contains a dash "-" character that can't be used when naming a variable. We can only use letters, | ||
> > numbers, dots, and underline "_" characters. | ||
> > 2widths - 2widths - We can't start a variable name with a number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is '2widths' repeated?
_episodes/01-rstudio-intro.md
Outdated
> > min-length - This contains a dash "-" character that can't be used when naming a variable. We can only use letters, | ||
> > numbers, dots, and underline "_" characters. | ||
> > 2widths - 2widths - We can't start a variable name with a number. | ||
> > if - If is a special case called a reserved word. We use it for control structures that will be discussed at a later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might say something like: "If
is a special type of word called a reserved word. There are about 20 of these reserved words, and they represent things that cannot be directly overwritten during normal use of the assignment operator because they are a core part of the language itself.
You should also give the PR a descriptive name that says what it does to the lesson. Then in the description text you can note that it is being submitted as part of instructor training. |
This is being submitted as part of my instructor training.
Hi @jordwil thanks for the modifications. I didn't notice this the first time, but your PR contains modifications to the |
Hi @jordwil - do you think you'll have a chance to migrate these changes over to the |
I can do this tomorrow.
… On Apr 29, 2017, at 1:41 PM, Naupaka Zimmerman ***@***.***> wrote:
Hi @jordwil <https://github.com/jordwil> - do you think you'll have a chance to migrate these changes over to the Rmd instead of the md files? Otherwise I'll close this PR since there hasn't been much activity for a few months.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#245 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADILtdNpg5wjoL3qVOUka81-7kFAdVF3ks5r06BygaJpZM4MCka_>.
|
Moving overview of existing lesson materials to Carpentries lesson.
Added an additional feature to the challenge, mainly to introduce reserved words as well as add descriptions to the solutions.