Challenge 1 Solution - Issue #603 #713
Conversation
This should solve #603 . The following changes were made: - Modified the first solution to be more consist with the other solutions by adding `Step 1:.. Step 2:` etc. - Modified "Now do the same for 2012" to "Do the same for 2012" so it's more clear what the learner needs to do. - Removed reference to `any()` to the bottom and labelled as alternative solutions - Added solution that uses `%in%`.
_episodes_rmd/07-control-flow.Rmd
Outdated
| > > print("Record(s) for the year 2002 found.") | ||
| > > } | ||
| > > ``` | ||
| > > Using the `any()` function, the logical condition can be expressed as: | ||
| > > ```{r ch10pt5-sol, eval=FALSE} |
There was a problem hiding this comment.
The chunk name should be updated so it is not a duplicate of the chunk name on line 133.
There was a problem hiding this comment.
Apologies, submitted correction to chunk name. Apologies for the multiple commits, I noticed my error too late.
Thank you.
|
Thanks, @ammaraziz . Could you update the PR so there are no duplicate chunk names in the markdown file? |
jcoliver
added
status:changes requested
This time removed duplicates for sure
|
Thanks for the update, @ammaraziz . At some point in the process, the formatting for the solution has gone awry. If you look at the Files changed tab for this PR or the file on your branch (https://github.com/ammaraziz/r-novice-gapminder/blob/patch-1/_episodes_rmd/07-control-flow.Rmd), note that the formatting is off starting around line 134. Most notably, the double greater than signs are missing |
This should solve #603 . The following changes were made:
Step 1:.. Step 2:etc.any()to the bottom and labelled as alternative solutions%in%.First (proper) pull request so please let me know if anything is wrong or needs correcting.
Ammar
Instructions
Thanks for contributing! ❤️
If this contribution is for instructor training, please email the link to this contribution to
checkout@carpentries.org so we can record your progress. You've completed your contribution
step for instructor checkout by submitting this contribution!
Keep in mind that lesson maintainers are volunteers and it may take them some time to
respond to your contribution. Although not all contributions can be incorporated into the lesson
materials, we appreciate your time and effort to improve the curriculum. If you have any questions
about the lesson maintenance process or would like to volunteer your time as a contribution
reviewer, please contact The Carpentries Team at team@carpentries.org.
You may delete these instructions from your comment.
- The Carpentries