Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure to fig #23

Merged
merged 9 commits into from
Jan 20, 2015
Merged

Figure to fig #23

merged 9 commits into from
Jan 20, 2015

Conversation

dhaine
Copy link
Contributor

@dhaine dhaine commented Jan 16, 2015

No description provided.

@dhaine
Copy link
Contributor Author

dhaine commented Jan 16, 2015

Changes /figure to /fig

@jdblischak
Copy link
Contributor

Great. This works for all the files in which we had explicitly set the name of the figures created. However, files which have not had this set will still save to figure/ by default. I am thinking we should update tools/chunk-options.R to save to fig/ by default. Thoughts?

@dhaine
Copy link
Contributor Author

dhaine commented Jan 20, 2015

I believe it is comming from 04-cond-colors-R.Rmd. But is this lesson not in conflict with 04-cond.Rmd?

@jdblischak
Copy link
Contributor

I haven't removed 04-cond-colors-R entirely because someone may want to revive it (though that is obviously unlikely). Do you think we should just delete it?

@dhaine
Copy link
Contributor Author

dhaine commented Jan 20, 2015

We could either remove it or put it in "stand-by" for a certain period (6 months?) to see if anybody would want to use it or work on it. In the meantime we can switch off the production of plots (e.g. eval=FALSE) and add a comment at beginning of file.

@jdblischak
Copy link
Contributor

If we leave it there and edit it, I think it would be better to just go ahead and redirect the figures by adding the following line:

opts_chunk$set(fig.path = "figure/04-cond-colors-R-")

@jdblischak jdblischak merged commit 667666d into swcarpentry:gh-pages Jan 20, 2015
@jdblischak
Copy link
Contributor

Thanks, @dhaine.

Would it be difficult for you to set the language of R to English temporarily when you run make preview? The merge conflicts were due to error messages being printed in French. I left them in there for now because it will be easier for me to simply update with a new PR than manually fix all the error messages.

@dhaine
Copy link
Contributor Author

dhaine commented Jan 20, 2015

I'll see to switch it permanently to English to avoid future errors. Thanks!

@dhaine dhaine deleted the figure-to-fig branch January 21, 2015 15:53
rgaiacs pushed a commit to rgaiacs/swc-r-novice-inflammation that referenced this pull request May 6, 2017
Adding empty episodes for intro, shell, scheduler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants