-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Tips to callout boxes #32
Conversation
Generated as `analyze-[number].png whereas previously seemed to be analyze[number].png
Thanks, @ateucher. I'll assign the issue to you. No need to commit files that are modified, but not really changed. However, when there are new files you should commit those. For example, the newest version of knitr now adds a dash before the number when there are multiple plots generated by the same chunk, i.e. it used to be |
It was an empty image
Well nevermind, I can't actually assign the issue to you. But since you referenced this Issue in this thread it should be fine. |
I've invited @ateucher to join the @swcarpentry team. |
Thanks @gvwilson! I've assigned myself now. |
Removes image files from the loops lesson that do not use a hyphen before the numeric suffix (as discussed in swcarpentry#34). This change is due to a change in figure numbering in the new version of knitr.
@jdblischak I think this PR is ready for review and merge if it's acceptable. I've changed all instances of |
Looks good. Thanks, @ateucher. |
Change Tips to callout boxes
Impostor syndrome
CSS cataloguing tool
This is a start on #20; reformatting the Tips as callout boxes. You don't need to merge this yet, as I'll add more commits to it, but I thought I would push up changes to the first files to get the PR started.
The figures were re-rendered when ran
make preview
, but are identical. Let me know if you don't want me to commit them.