Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Tips to callout boxes #32

Merged
merged 9 commits into from
Jan 28, 2015
Merged

Conversation

ateucher
Copy link
Contributor

This is a start on #20; reformatting the Tips as callout boxes. You don't need to merge this yet, as I'll add more commits to it, but I thought I would push up changes to the first files to get the PR started.

The figures were re-rendered when ran make preview, but are identical. Let me know if you don't want me to commit them.

@ateucher ateucher mentioned this pull request Jan 27, 2015
@jdblischak
Copy link
Contributor

Thanks, @ateucher. I'll assign the issue to you.

No need to commit files that are modified, but not really changed. However, when there are new files you should commit those. For example, the newest version of knitr now adds a dash before the number when there are multiple plots generated by the same chunk, i.e. it used to be chunk-plot2.png but now it is chunk-plot-2.png.

It was an empty image
@jdblischak
Copy link
Contributor

Well nevermind, I can't actually assign the issue to you. But since you referenced this Issue in this thread it should be fine.

@gvwilson
Copy link
Contributor

I've invited @ateucher to join the @swcarpentry team.

@ateucher ateucher self-assigned this Jan 27, 2015
@ateucher
Copy link
Contributor Author

Thanks @gvwilson! I've assigned myself now.

@ateucher ateucher removed their assignment Jan 27, 2015
Removes image files from the loops lesson that do not use a hyphen before the numeric suffix (as discussed in swcarpentry#34). This change is due to a change in figure numbering in the new version of knitr.
@ateucher
Copy link
Contributor Author

@jdblischak I think this PR is ready for review and merge if it's acceptable. I've changed all instances of **Tip:** to use the ## Tip {.callout}.

@ateucher ateucher mentioned this pull request Jan 28, 2015
@jdblischak
Copy link
Contributor

Looks good. Thanks, @ateucher.

jdblischak added a commit that referenced this pull request Jan 28, 2015
Change Tips to callout boxes
@jdblischak jdblischak merged commit f8fb06d into swcarpentry:gh-pages Jan 28, 2015
@ateucher ateucher deleted the 20-fix-tips branch January 28, 2015 04:12
rgaiacs pushed a commit to rgaiacs/swc-r-novice-inflammation that referenced this pull request May 6, 2017
rgaiacs pushed a commit to rgaiacs/swc-r-novice-inflammation that referenced this pull request May 6, 2017
zkamvar pushed a commit that referenced this pull request May 1, 2023
Change Tips to callout boxes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants